test: remove unreachable code in pytest.raises block, fix some malformed tests, extract fixtures #1800
+146
−271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1800 +/- ##
=======================================
Coverage 97.95% 97.96%
=======================================
Files 60 60
Lines 2646 2648 +2
=======================================
+ Hits 2592 2594 +2
Misses 54 54 ☔ View full report in Codecov by Sentry. |
bearomorphism
force-pushed
the
test-pyraise-one-statement
branch
2 times, most recently
from
66a240f to
fcbfb0a
Compare
…med tests and extract fixtures
bearomorphism
force-pushed
the
test-pyraise-one-statement
branch
from
fcbfb0a to
2424f3f
Compare
bearomorphism
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
with pytest.raisesblock should contain only one statement which we expect it to throw exceptions.Changes made
test_check_command_cli_overrides_config_message_length_limit. The lastcheck_cmdassignment had no effect.success_mockandcommit_mock